On 2021/03/30 17:16, Jonathan Gray wrote:
> On Tue, Mar 30, 2021 at 07:58:10AM +0200, Theo Buehler wrote:
> > piglit failed to build in a bulk due to a missing dependency. Patch
> > below fixed the build for me.
> >
> > [3320/4182] cd
> > /tmp/pobj/piglit-20210128/build-amd64/target_api/gl/tests/spec/ext_external_objects
> > && /usr/local/bin/glslangValidator -V
> > /tmp/pobj/piglit-20210128/piglit-83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/vk_blue.vert
> > -o
> > /tmp/pobj/piglit-20210128/piglit-83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/vk_blue.vert.spv
> > FAILED:
> > /tmp/pobj/piglit-20210128/piglit-83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/vk_blue.vert.spv
> > cd
> > /tmp/pobj/piglit-20210128/build-amd64/target_api/gl/tests/spec/ext_external_objects
> > && /usr/local/bin/glslangValidator -V
> > /tmp/pobj/piglit-20210128/piglit-83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/vk_blue.vert
> > -o
> > /tmp/pobj/piglit-20210128/piglit-83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/vk_blue.vert.spv
> > /bin/sh: /usr/local/bin/glslangValidator: not found
> > ninja: build stopped: subcommand failed.
> > *** Error 1 in graphics/piglit (/usr/ports/devel/cmake/cmake.port.mk:36
> > 'do-build': @cd /tmp/pobj/piglit-20210128/build-amd64 && exec /usr/b...)
> > *** Error 2 in graphics/piglit
> > (/usr/ports/infrastructure/mk/bsd.port.mk:2943
> > '/tmp/pobj/piglit-20210128/build-amd64/.build_done': @cd /usr/...)
> > *** Error 2 in graphics/piglit
> > (/usr/ports/infrastructure/mk/bsd.port.mk:2602 'build':
> > @lock=piglit-20210128; export _LOCKS_HELD=" piglit-2...)
> > ===> Exiting graphics/piglit with an error
> > *** Error 1 in /usr/ports (infrastructure/mk/bsd.port.subdir.mk:137
> > 'build': @: ${echo_msg:=echo}; : ${target:=build}; for i in ; do eval...
>
> ok jsg@ though there is something odd here as there is a build time
> check for it before it is used:
>
> https://github.com/mesa3d/piglit/blob/83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/CMakeLists.gl.txt#L36
Packages get installed and uninstalled all the time during a
bulk build, something checked for in configure needs to be listed
as a BUILD/LIB_DEPENDS otherwise it may try to use it later but
it's already been uninstalled by that point.
