On Thu, 25 Mar 2021 10:50:58 +0100
Florian Viehweger <open...@out-of-creativity.de>:

> Hi,
> 
> > In the README you have "${SYSCONFDIR}/inetd.conf", this should just be
> > /etc not ${SYSCONFDIR} because inetd is a system daemon not a ports
> > one. Also some whitespace issues in the relayd config (4 spaces then
> > a tab, I think maybe your editor is set to ts=4? the indent is wrong
> > when viewed in a normal terminal). That's in this bit:
> > 
> >     relay "gemini" {
> >             listen on hostname.example port 1965 tls
> >             protocol "gemini"
> >             forward to 127.0.0.1 port 11965
> >     }  
> 
> These issues might be from copying and pasting files around. I use a
> default as possible VM for doing ports-stuff.
> 
> > Executing a new process is relatively resource intensive, most network
> > daemons handling short-lived requests moved away from this model in
> > the 80's-90's. Even the original UM gopher daemon served directly
> > (inetd support wasn't even present in the earlier releases, I would
> > speculate that maybe it was added later so people could run it under
> > the radar without appearing in a typical ps listing ;-)  
> 
> Thank you for the explanation. :-)
> 
> This time I added the diff for user.list as an attachment as opposed to
> inline.
> 

The ports looks fine to me, ok for import

The pkg/DESCR could be wrapped with fmt 60, it would look better
but that's all I see.

Reply via email to