On Sun, Mar 21, 2021 at 11:01:54AM -0400, Brennan Vincent wrote: > Attaching a patch that follows these suggestions. > > My ports tree is a checkout of the https://github.com/openbsd/ports mirror, > so I've used git format-patch to create the patch. I'm a porting beginner so > please let me know if there's a better way to send patches. The Makefile looks all good, thank you. Just indent with tabs not spaces like the rest of the file, please.
> diff --git a/x11/xsel/patches/patch-configure > b/x11/xsel/patches/patch-configure > deleted file mode 100644 > index 7ee76777a43..00000000000 > --- a/x11/xsel/patches/patch-configure > +++ /dev/null > @@ -1,15 +0,0 @@ > -$OpenBSD: patch-configure,v 1.2 2014/07/07 08:22:52 sthen Exp $ > - > --Wdeclaration-after-statement is gcc 4-only. > - > ---- configure.orig Mon Mar 24 15:27:33 2008 > -+++ configure Mon Jul 7 09:22:18 2014 > -@@ -5880,7 +5880,7 @@ fi > - > - # Error out on compile warnings > - if test "x$ac_cv_c_compiler_gnu" = xyes ; then > -- CFLAGS="$CFLAGS -fno-strict-aliasing -Wall -Werror -g -std=gnu99 > -Wdeclaration-after-statement -Wno-unused" > -+ CFLAGS="$CFLAGS -fno-strict-aliasing -Wall -Werror -g -std=gnu99 > -Wno-unused" These flags are still used. Were they removed to support building on GCC 3.x platforms? If so -and I think there are some- you'd have to still remove them, I guess. > - fi > - > - # Checks for header files.
