On Wed Mar 03, 2021 at 06:21:35PM +0000, Stuart Henderson wrote:
> On 2021/02/27 09:43, Rafael Sadowski wrote:
> > +_MODCMAKE_ARGS += -DCMAKE_C_COMPILER="${CC}" \
> > + -DCMAKE_CXX_COMPILER="${CXX}" \
> > + -DCMAKE_C_FLAGS="${CFLAGS}" \
> > + -DCMAKE_C_FLAGS_DEBUG="${CFLAGS}" \
> > + -DCMAKE_C_FLAGS_RELEASE="${CFLAGS}" \
>
> I just found something with
>
> -set(CMAKE_C_FLAGS_RELEASE "-O3 -DNDEBUG")
It is good if we override this, isn't?
>
> I worry that overriding this is going to cause things to quietly build
> with bad flags..
>
I see your point but I don't understand what you mine with "bad flags".
Application build/link "bad" flags?
In this example we can't override CMAKE_C_FLAGS_RELEASE because FORCE is
set.
net/ettercap/patches/patch-CMakeLists_txt
+set(CMAKE_C_FLAGS_RELEASE "-w -D_FORTIFY_SOURCE=2" CACHE STRING "" FORCE)
