Here is the diff: you'll see that it need i3 only for building. Users can use polybar without i3.
Le 01/03/2021 à 09:05, Guy Godfroy a écrit : > You need i3 only if you want to use i3 module. You can just omit it in > your config file if you're not using i3. > > So, for sure I should add i3 as a build dependency. But as installing > polybar doesn't install i3 as a run dependency, I don't see why we > should split the program in 2 separate packages. > > Le 27/02/2021 à 13:03, Jasper Lievisse Adriaanse a écrit : >> On Tue, Feb 23, 2021 at 10:41:39AM +0100, Guy Godfroy wrote: >>> Hello, >>> >>> Thanks to recent py-sphinx update, here is the diff to update polybar. >>> >>> On the old version of the port, i3 support was explicitly disabled, >>> don't know why. I re-enabled it and it works fine. >> >> It was clearly stated in the commit message of -r1.4 at the time actually: >> >> "disable i3 support for now; it gets picked up during configure (though we >> had no BDEP on it) >> and I don't think it's worthwhile yet to force i3 as a dependency of >> polybar. we can still >> add an -i3 subpackage if there is a request for it." >> >> Your latest diff does work, though I still see no point in enabling i3 >> support for the sake >> of enabling it. If i3 support is much desired, please make it a subpackage >> to prevent >> forcing that dependency on those who use polybar with a different wm. >> >> For now I've committed your update, thanks. >> >> Cheers, >> Jasper >>
? maildiff Index: Makefile =================================================================== RCS file: /cvs/ports/x11/polybar/Makefile,v retrieving revision 1.14 diff -u -p -r1.14 Makefile --- Makefile 27 Feb 2021 12:03:43 -0000 1.14 +++ Makefile 1 Mar 2021 09:26:32 -0000 @@ -3,6 +3,7 @@ COMMENT = fast and easy-to-use status bar V = 3.5.4 DISTNAME = polybar-$V +REVISION = 1 CATEGORIES = x11 HOMEPAGE = https://polybar.github.io/ @@ -29,7 +30,9 @@ DEBUG_PACKAGES =${BUILD_PACKAGES} MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3} BUILD_DEPENDS = ${RUN_DEPENDS} \ - textproc/py-sphinx${MODPY_FLAVOR}>=2.4.3 + textproc/py-sphinx${MODPY_FLAVOR}>=2.4.3 \ + devel/jsoncpp \ + x11/i3 LIB_DEPENDS = audio/libmpdclient \ audio/pulseaudio \ @@ -43,7 +46,6 @@ RUN_DEPENDS = x11/py-xcbgen${MODPY_FLAVO CONFIGURE_ARGS = -DENABLE_CCACHE=OFF \ -DCMAKE_EXE_LINKER_FLAGS="-L${LOCALBASE}/lib -lintl -L${LOCALBASE}/lib/inotify -linotify -Wl,-rpath,${LOCALBASE}/lib/inotify" \ - -DENABLE_I3=OFF NO_TEST = Yes
