On 2021/02/25 22:49, Stefan Krah wrote: > On Thu, Feb 25, 2021 at 09:33:39PM +0000, Stuart Henderson wrote: > > > it would be nice to add math/mpdecimal. If the port is accepted, Python > > > > Please send as an attachment > > Ok, here it is.
thanks - some quick comments, the Makefile should look more like other Makefiles in ports, you are at least missing a license marker, and the order is a bit different to the standard (it's not absolutely cast in stone but generally lines should be in the same order as in ports/infrastructure/Makefile.template) library versioning doesn't follow openbsd standards. libraries need to be listed in SHARED_LIBS and that needs to control the version number in the produced libraries (change SHARED_LIBS -> library changes in the build). openbsd uses .so.X.Y and doesn't use use .so / .so.X symlinks, ports should start with .so.0.0 irrespective of what upstream uses. there's some more info in https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs missing WANTLIB, see "make port-lib-depends-check" C++ ports always need a COMPILER line, usually COMPILER= base-clang ports-gcc the WWW link (HOMEPAGE) is added automatically, don't set it yourself in DESCR otherwise it is duplicated portcheck(1) may spot other things
