On 21/02/09 11:08, Stuart Henderson wrote:
> Quick comments from a read-through, I have not tried building:
>
>
> ports fetching from github /archive/ URLs should use GH_* variables
> not MASTER_DISTES - see ports/infrastructure/Makefile.template
>
> the patches directory should be generated with "make update-patches",
> don't split patches between patches/ and files/
>
> DESCR should describe what it does and should not just be a copy
> of COMMENT
>
> leave out MAINTAINER completely if you aren't going to set it to
> yourself
>
> the library should be generated directly with ports versioning,
> no symlinks
>
> instead of setting PORT_LIB_MAJOR/PORT_LIB_MINOR, take it from
> the SHARED_LIBS setting by using ${LIBigdgmm_VERSION:R} for major
> and ${LIBigdgmm_VERSION:E} for minor
>
> see other ports or Makefile.template for the expected style
> for CONFIGURE_ARGS / LIB_DEPENDS (one per line) and WANTLIB
> (not one per line), don't use "c++" in WANTLIB that is covered
> by COMPILER_LIBCXX, there is no such thing as COMPILER_LIBC
>
Thank you, for following up. Still learning ports, now that I know that
it builds, time to make it right. I could be a mantainer, if nobody else
wants the pleasure.
P.S. sorry for double, forgot to set cc
--
Eugene Moz.
signature.asc
Description: PGP signature
