Some features are broken in openbsd serf on 6.8
This may break some apache2 (?) feature or subversion
and OpenOffice

Openbsd is on  the 1.3.8 google code repo which is deprecated and
apache foundation released a new version with up to date

Index: Makefile
===================================================================
RCS file: /cvs/ports/net/serf/Makefile,v
retrieving revision 1.13
diff -u -p -r1.13 Makefile
--- Makefile    12 Jul 2019 20:48:48 -0000      1.13
+++ Makefile    3 Feb 2021 15:04:44 -0000
@@ -1,10 +1,10 @@
 # $OpenBSD: Makefile,v 1.13 2019/07/12 20:48:48 sthen Exp $

 COMMENT =              high performance HTTP client library
-DISTNAME =             serf-1.3.8
+DISTNAME =             serf-1.3.9
 SHARED_LIBS =          serf-1                    1.0 # 1.3.0
 CATEGORIES =           net
-HOMEPAGE =             https://code.google.com/p/serf/
+HOMEPAGE =             https://serf.apache.org/
 MAINTAINER =           Stefan Sperling <s...@openbsd.org>
 REVISION =             0

@@ -12,7 +12,7 @@ REVISION =            0
 PERMIT_PACKAGE =       Yes

 WANTLIB =              apr-1 aprutil-1 crypto db expat iconv pthread ssl z
-MASTER_SITES =         https://serf.googlecode.com/svn/src_releases/
+MASTER_SITES =         https://www.apache.org/dist/serf/
 EXTRACT_SUFX =         .tar.bz2

 MODULES =              devel/scons
Index: distinfo
===================================================================
RCS file: /cvs/ports/net/serf/distinfo,v
retrieving revision 1.6
diff -u -p -r1.6 distinfo
--- distinfo    17 Dec 2014 09:43:39 -0000      1.6
+++ distinfo    3 Feb 2021 15:04:44 -0000
@@ -1,2 +1,2 @@
-SHA256 (serf-1.3.8.tar.bz2) = 4FAL4GXbvOSQRJg3uyq2JORtZPwLCQR02ayqh8grJZA=
-SIZE (serf-1.3.8.tar.bz2) = 143337
+SHA256 (serf-1.3.9.tar.bz2) = VJwtIcV3qKnARQ+stcyoCfJlkfBI5GZVIkCUe996h8w=
+SIZE (serf-1.3.9.tar.bz2) = 145132
cvs server: Diffing pkg


and those patches
--- /usr/ports/pobj/serf-1.3.9/serf-1.3.9/buckets/ssl_buckets.c.orig
 Tue Feb  2 19:34:11 2021
+++ /usr/ports/pobj/serf-1.3.9/serf-1.3.9/buckets/ssl_buckets.c Tue
Feb  2 19:34:38 2021
@@ -1156,11 +1156,7 @@
         }
 #endif

-#ifdef USE_OPENSSL_1_1_API
-        OPENSSL_malloc_init();
-#else
         CRYPTO_malloc_init();
-#endif
         ERR_load_crypto_strings();
         SSL_load_error_strings();
         SSL_library_init();
--- /usr/ports/pobj/serf-1.3.9/serf-1.3.9/test/server/test_sslserver.c.orig
    Tue Feb  2 19:35:38 2021
+++ /usr/ports/pobj/serf-1.3.9/serf-1.3.9/test/server/test_sslserver.c
 Tue Feb  2 19:36:04 2021
@@ -228,11 +228,7 @@
     /* Init OpenSSL globally */
     if (!init_done)
     {
-#ifdef USE_OPENSSL_1_1_API
-        OPENSSL_malloc_init();
-#else
         CRYPTO_malloc_init();
-#endif
         ERR_load_crypto_strings();
         SSL_load_error_strings();
         SSL_library_init();



[0]-[square]-[square]-[-09:59]-[/usr/ports/net/serf]# ls ./patches/
patch-buckets_ssl_buckets_c           patch-test_server_test_sslserver_c
# make test
===>  Regression tests for serf-1.3.9p0


There's A lot of errors

There were 15 failures:
1) test_ssl_handshake: test/test_util.c:456: expected <0> but was <120199>
2) test_ssl_trust_rootca: test/test_util.c:456: expected <0> but was <120199>
3) test_ssl_certificate_chain_with_anchor: test/test_util.c:456:
expected <0> but was <120199>
4) test_ssl_certificate_chain_all_from_server: test/test_util.c:456:
expected <0> but was <120199>
5) test_ssl_no_servercert_callback_allok: test/test_util.c:456:
expected <0> but was <120170>
6) test_ssl_large_response: test/test_util.c:456: expected <0> but was <120170>
7) test_ssl_large_request: test/test_util.c:456: expected <0> but was <120170>
8) test_ssl_client_certificate: test/test_util.c:456: expected <0> but
was <120170>
9) test_ssl_future_server_cert: test/test_util.c:456: expected <0> but
was <120199>
10) test_setup_ssltunnel: test/test_util.c:456: expected <0> but was <120170>
11) test_ssltunnel_basic_auth: test/test_context.c:2138: expected <0>
but was <120170>
12) test_ssltunnel_basic_auth_server_has_keepalive_off:
test/test_context.c:2138: expected <0> but was <120170>
13) test_ssltunnel_basic_auth_proxy_has_keepalive_off:
test/test_context.c:2138: expected <0> but was <120170>
14) test_ssltunnel_basic_auth_proxy_close_conn_on_200resp:
test/test_context.c:2138: expected <0> but was <120170>
15) test_ssltunnel_digest_auth: test/test_util.c:456: expected <0> but
was <120170>

!!!FAILURES!!!
Runs: 66 Passes: 51 Fails: 15

It still better than in 6.7 , make test completely explode

== Testing test/testcases/simple.response ==
== Running the unit tests ==
ERROR: test(s) failed in test_all
scons: *** [check] Error 1
scons: building terminated because of errors.

I will contact the serf mailing list separately,
The main problem is related to some update in libressl regarding
certification validation,
and my guess is serf is not using the right argument.

Main issue is connecting to an ssl server using a home made CA.

Are the patches ok to work with libressl ?

-- 
--
---------------------------------------------------------------------------------------------------------------------
Knowing is not enough; we must apply. Willing is not enough; we must do

Reply via email to