On Thu Jan 28, 2021 at 09:24:24AM +0000, Stuart Henderson wrote:
> Simplest is probably to use .if defined. DISTNAME is defined for GH_* around
> line 620 in bsd.port.mk, MODULES files are included much earlier.
Thanks, fix committed.
>
> I didn't run into this when I tested the ksnip submission though?
No because I changed to use the kf5 MODULE. All ports that use
devel/kf5/extra-cmake-modules should use the kf5 MODULE.
>
> --
> Sent from a phone, apologies for poor formatting.
> On 28 January 2021 05:59:50 Rafael Sadowski <raf...@sizeofvoid.org> wrote:
>
> > Hi porters,
> >
> > in ports that use the kf5 module and have only set GH_*, I get the
> > following message.
> >
> > For example:
> >
> > GH_ACCOUNT = ksnip
> > GH_PROJECT = ksnip
> > GH_TAGNAME = v1.8.0
> >
> > MODULES = devel/kf5
> >
> > $ make configure
> > *** Parse error in /usr/ports/graphics/ksnip: Malformed conditional
> > (${DISTNAME:Nextra-cmake-modules-*})
> > (/usr/ports/devel/kf5/kf5.port.mk:9)
> > *** Parse error: Missing dependency operator
> > (/usr/ports/devel/kf5/kf5.port.mk:9)
> >
> > Is DISTNAME perhaps not set at that point? Any idea how to fix it
> > cleanly? This check is important for the module, of course.
> >
> > Cheers,
> >
> > Rafael
>
