On Wed, 20 Jan 2021, wen heping wrote:

> Hi, ports@:
> 
>   Here is a patch for geo/pygeoapi:
>     i) Update to 0.9.0

What's the benefit of the update? What changed?

>     ii) Add 2 missing DEPENDS

If you can show me how to test this port, I can commit it with some 
tweaks.

Same issue as the other port where we're relying on implicit dateutils via 
click, rather than making it an explicit depend. We should fix that.

> 
>   It build well and run well on amd64-current system,

Running portcheck complains about some trailing whitespace in DESCR. May 
as well fix that if we're doing an update.

> there is no test defined and no other ports depends on it.

True, but the commented out TEST_DEPENDS looks wrong to me. I think it 
should be
    TEST_DEPENDS +=
instead of
    TEST_DEPENDS =

(if we ever get the tests going, the former will make sure pytest is 
installed for the tests).

speaking of which, does pulling the distfile from github rather than pypi 
let us run the tests?

> 
> 
> Cheers !
> wen
> 

Reply via email to