Thanks for the help! I've made the changes you suggested, please could you take a look?
On Sat, 16 Jan 2021, at 2:55 PM, Stuart Henderson wrote: > On 2021/01/16 13:41, Reeto Chatterjee wrote: > > Bump > > No patch attached. > > > > On 3 Dec 2020, at 03:14, Reeto Chatterjee <m...@ree.to> wrote: > > > > > > Hi, > > > > > > I’ve attached a small patch to update ddclient from 3.8.3 to 3.9.1. The > > > project has moved to GitHub (as noted on the old sourceforge homepage) > > > and the dependencies have changed slightly. I’ve updated the dependencies > > > from the README https://github.com/ddclient/ddclient/tree/v3.9.1 . > > > > > > I had a couple of questions: > > > 1) How are optional dependencies generally handled? JSON, IPv6 and SSL > > > seem to be optional. Currently I’ve added them all to the runtime > > > dependencies. > > Generally for optional dependencies which are checked at *run* time: > > If they're small and quite useful, include them. > > If they're huge (or have a big chain of dependencies themselves) and not > very useful, don't. > > If they're in between, make a judgment call. > > > > 2) Should the REVISION remain at 1 or be reset to 0 when upgrading > > > versions? I’ve left it as 1. > > Please remove the line completely. > > > > I lack the knowledge of Perl to do the security review that the Porting > > > guide mentions, so please could someone take a look (if it’s necessary). > > > > > > Finally, I don’t have commit access to CVS. If this looks alright, please > > > could someone run the committing commands? > > > > > > Thanks! > > > > > > Reeto > > > > > > <patch> > > > >
patch.diff
Description: Binary data
