On 2021/01/03 19:46, Jeremie Courreges-Anglas wrote: > On Sun, Jan 03 2021, Dimitri Karamazov <deserter...@danwin1210.me> wrote: > > Update graphics/openimageio to 2.2.10.0 > > > > Build & run tested blender with it. > > 14 out of 54 tests fail. > > Atleast 3 of them fail because of some > > optional dependencies not being turned on. > > Like OpenVDB,libheif and ptex. > > > Removed the USE_DICOM option since it > > is optional now. > > It may be optional, but it is still used if available: > > (after a make configure) > --8<-- > russell /usr/ports/graphics/openimageio$ doas pkg_delete dcmtk > dcmtk-3.6.3p0: ok > Read shared items: ok > russell /usr/ports/graphics/openimageio$ make all MAKE_JOBS=2 2>&1 | tee log2 > ===> Building for openimageio-2.2.10.0 > ninja: error: '/usr/local/lib/libdcmimage.so.0.0', needed by > 'lib/libOpenImageIO.so.8.0', missing and no known rule to make it > -->8-- > > Optional deps for which we have ports should be explicitely enabled or > disabled, to avoid problems during bulk builds. See the commit log:
yes - I'd go further actually, s/for which we have ports//. Then you don't need to search the ports tree to see if they exist, and it also covers the case where some library is added to ports later. > While here, openimageio is only used by blender, for which you're the > new maintainer. Should you also take over maintainership of this port? that would seem sensible!
