On Sun, Jan 03 2021, Landry Breuil <lan...@openbsd.org> wrote: > Hi, > > here's an update to libofx, cf > https://github.com/libofx/libofx/releases/tag/0.10.0. > > i've successfully built all its consumers > (productivity/{gnucash,grisbi,kmymoney,homebank} but i havent tested > those at runtime, so feedback from users of the OFX format is welcome.
Well I'm no OFX format user but I took a look: - nm(1) or check_sym mention only additions but the layout of a bunch of structures in libofx.h have changed (additional members, size changes). I think a major bump is warranted. - the build tries to use -fvisibility but fails for a stupid reason: --8<-- configure:3742: checking for symbol visibility extensions configure:3754: c++ -fvisibility-inlines-hidden -fvisibility=hidden -Werror -S conftest.c -o conftest.s 1>&5 c++: error: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Werror,-Wdeprecated] configure:3757: $? = 1 configure:3768: result: no -->8-- configure.ac hardcodes the use of a .c file. This is something upstream might want to fix. You can work around it by overriding ac_cv_sym_visibility, this would trigger the use of -fvisibility and largely reduce the number of exported symbols. (Obviously this also warrants a major bump and has an impact on consumers.) My two cents, -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
