On Mon 28/12/2020 17:25, Charlene Wendling wrote:
> Ping.
> 
> On Mon, 21 Dec 2020 15:11:54 +0100
> Charlene Wendling wrote:
> 
> > On Sat, 19 Dec 2020 16:09:50 +0200
> > Timo Myyrä wrote:
> > 
> > > Charlene Wendling <juliana...@posteo.jp> [2020-12-12, 13:37 +0100]:
> > > 
> > > > Hi,
> > > >
> > > > On Sat, 05 Dec 2020 09:25:26 +0200
> > > > Timo Myyrä wrote:
> > > >
> > > >> Hi,
> > > >> 
> > > >> This updates icewm to latest release, works for me on amd64.
> > > >> 
> > > >> timo
> > > >
> > > > I've tested it successfully on macppc and amd64. OK cwen@
> > > >
> > 
> > > 
> > > Icewm had new release since, here's updated diff.
> > > This version changes the default image rendering library from
> > > gdb-pixbuf-xlib to Imlib2 so I changed the port as well to use
> > > Imlib2.
> > 
> > I think it's great to do it right now so we won't have any problem
> > later (gdk-pixbuf-xlib has been deprecated and archived by GNOME [0]).
> > 
> > > Works for me on amd64.
> > > 
> > > timo
> > > 
> > 
> > Looks like gdk-pixbuf-xlib used to pull some libraries that are now
> > missing; in an empty chroot i get: 
> > 
> > Missing library for gio-2.0>=0.0
> > Missing library for glib-2.0>=0.0
> > Missing library for gmodule-2.0>=0.0
> > Missing library for gobject-2.0>=0.0
> > Missing library for pcre>=0.0
> > 
> > port-lib-depends-check was not happy and asked for more LIB_DEPENDS
> > as well:
> > 
> > icewm-2.0.0(x11/icewm):
> > Missing lib: cairo.13 (/usr/local/bin/icewmbg) (NOT REACHABLE)
> > Missing lib: gdk_pixbuf-2.0.3200 (/usr/local/bin/icewmbg) (NOT
> > REACHABLE) Missing lib: harfbuzz.15 (/usr/local/bin/icewmbg) (NOT
> > REACHABLE) Missing lib: pango-1.0.3801 (/usr/local/bin/icewmbg) (NOT
> > REACHABLE) Missing lib: pangocairo-1.0.3801 (/usr/local/bin/icewmbg)
> > (NOT REACHABLE) Missing lib: pangoft2-1.0.3801
> > (/usr/local/bin/icewmbg) (NOT REACHABLE) Missing lib: rsvg-2.38
> > (/usr/local/bin/icewmbg) (NOT REACHABLE) Missing lib: xml2.16
> > (/usr/local/bin/icewmbg) (NOT REACHABLE)
> > 
> > I added them all explicitly; we could reduce the number of
> > LIB_DEPENDS lines by playing with implicit dependencies (like
> > gdk_pixbuf-2.0.3200 pulling xml2.16). But as seen by this update, it's
> > a dangerous game to play.
> > 
> > I've modified your diff below.
> > 
> > This builds and works fine on amd64 and macppc, i've tested a number
> > of themes, and met no issues with standard themes. Other themes may
> > have a titlebar buttons issue, with the leftmost icon on the right
> > side being slightly mangled.
> > 
> > Charlène.
> > 
> > 
> > [0] https://gitlab.gnome.org/Archive/gdk-pixbuf-xlib


Build- and (lightly) run-tested on amd64. One (very) minor comment:
patches/patch-lib_Makefile_in and patches/patch-src_icesh_cc should be
updated using 'make update-patches'.

OK bket@

Reply via email to