On 2020/12/16 10:57, Renaud Allard wrote:
> Hello,
>
> Here is my first attempt at making xpra available on OpenBSD.
> Suggestions/corrections/tests are welcome.
>
> xpra is a kind of tmux/screen for X11
>
> Regards
Initial comments from a quick read through (I have not tried building) -
COMMENT = Xpra gives you persistent remote applications for X
please don't repeat the name here, when it's displayed it is close to the
package name anyway so there's duplication. Something like "persistent
remote applications for X" maybe?
DISTNAME = xpra-${MODPY_EGG_VERSION}
PKGNAME = ${DISTNAME:S/py/py-/}
REVISION = 0
the PKGNAME setting here doesn't make sense (it's a noop)
start with no REVISION
MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
BUILD_DEPENDS = [...] x11/py-gtk2
this doesn't make sense, py-gtk2 is py2 only
WANTLIB += ${COMPILER_LIBCXX} ${MODPY_WANTLIB}
if you have a WANTLIB on something from ports there should be an
associated LIB_DEPENDS (i.e. on ${MODPY_LIB_DEPENDS}) not just
a RUN_DEPENDS.
