On Wed, Dec 16, 2020 at 02:15:43AM +0100, Charlene Wendling wrote:
> Hi,
> 
> > http://build-failures.rhaalovely.net/powerpc/2020-11-27/geo/spatialite/gui.log
> > http://build-failures.rhaalovely.net/sparc64/2020-12-09/geo/spatialite/gui.log
> > http://build-failures.rhaalovely.net/mips64/2020-12-10/geo/spatialite/gui.log
> 
> This is what config.log says:
> 
> > configure:18572: cc -o conftest -O2 -pipe -I/usr/local/include
> > -L/usr/local/lib conftest.c -lpq  -lrasterlite2 -lspatialite
> > -lspatialite -lspatialite -lminizip -lproj -lsqlite3 -L/usr/local/lib
> > -lgeos_c >&5
> > [...]
> > /usr/bin/ld: warning: libfontconfig.so.13.0, needed by
> > /usr/local/lib/librasterlite2.so.0.0, not found
> > /usr/bin/ld: warning: libfreetype.so.30.0, needed
> > by /usr/local/lib/librasterlite2.so.0.0, not found
> > [...and many more, not only about rasterlite2...]
> 
> Indeed, useless libraries flags for this test are used. See
> ${WRKSRC}/configure.ac, the previous AC_CHECK_LIBS have populated
> LIBS, because no "action-is-found" is defined [0].
> 
> LDFLAGS are already provided, but are discarded during the test.
> 
> We could totally bypass the test as mentioned in the diff comment.
> Or playing with autotools. Yet, i'm proposing to add -L${X11BASE} to
> LIBS, only for ld.bfd archs, because it seems to me the better
> compromise.

> This allows spatialite-gui to be built on macppc. Runtime is working
> but is very slow as soon as i start querying a db. REVISION is not
> needed, this version never built on ld.bfd archs.

> Comments/feedback are welcome,
> Charlène.

> [0] 
> https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Libraries.html

This fixes the build on sparc64.

ok kmos

--Kurt

> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/geo/spatialite/gui/Makefile,v
> retrieving revision 1.17
> diff -u -p -u -p -r1.17 Makefile
> --- Makefile  11 Oct 2020 16:37:53 -0000      1.17
> +++ Makefile  16 Dec 2020 01:10:40 -0000
> @@ -37,6 +37,16 @@ CONFIGURE_ENV =            CPPFLAGS="-I${LOCALBASE
>                       LDFLAGS="-L${X11BASE}/lib -L${LOCALBASE}/lib"
>  
>  CONFIGURE_ARGS +=    --disable-xlsxwriter
> +
> +# Checking libpq fails on ld.bfd archs; LIBS is crowded with flags coming
> +# from other configure AC_CHECK_LIB checks, pulling X11 libraries.
> +# ac_cv_lib_pq_PQconnectdb="yes" could have been used as well. The extra
> +# space matters.
> +.include <bsd.port.arch.mk>
> +.if !${PROPERTIES:Mlld}
> +CONFIGURE_ENV +=     LIBS="-L${X11BASE}/lib "
> +.endif
> +
>  post-install:
>       ${INSTALL_DATA_DIR} ${PREFIX}/share/{pixmaps,applications}
>       ${INSTALL_DATA} ${WRKSRC}/gnome_resource/*.desktop 
> ${PREFIX}/share/applications/
> 

Reply via email to