Sebastien Marie wrote: > On Thu, Nov 12, 2020 at 08:09:32AM +0100, Stefan Hagen wrote: > > Charlene Wendling wrote: > > > On Wed, 11 Nov 2020 21:30:36 +0100 > > > Stefan Hagen wrote: > > > > > > > Charlene Wendling wrote: > > > > > The latest Luakit update fix the build on macppc [0]. There is no > > > > > runtime issue with the fixed webkitgtk4. > > > > > > > > > > OK? > > > > > > > > I've attached you the latest luakit with the missing dependencies > > > > for the test suite. So "make test" should work in the luakit port > > > > dir. > > > > > > > > The image_css test fails here more often than not. But everything > > > > else should succeed. > > > > > > It builds and works well on macppc. Tests are passing, excepted a few > > > who are failing due to expected timeout, and they call git (that should > > > be patched out). > > > > OK from my side then. > > > > Below is the current version including your change and with > > NO_TESTS = yes, because the test dependencies are not yet imported. > > > > I commited the test dependencies (now I had a second ok from someone. thanks > cwen@). > > Here an updated diff for luakit. > > As cwen@ noted, the git call in tests could be annoying in some > situations. So I patched it out. Maybe it could be done conditionally > if a ".git" directory exists. > > Stefan, are you fine with this diff ? it is based on your.
OK from my side. Thank you. Best Regards, Stefan
