Ashton Fagg <ash...@fagg.id.au> writes:
> Omar Polo <o...@omarpolo.com> writes:
>
>> [...snip...]
>> The port is straightforward. I believe that the comment and the DESCR
>> could be improved, but that was the best I was able to write, help
>> appreciated.
>>
>> The last minute doubt is if audio is a better category than multimedia.
>
> Hey,
>
> So I gave this a try. It builds ok. But running "make test" seems to
> fail.
>
> At a brief look I can't see anything that stands out as unit and/or
> regression tests, so you should add:
>
> # No tests from upstream
> NO_TEST = Yes
>
> to the Makefile so make test doesn't error out.
There is a regression test, but under a different target (‘check’) than
the default ‘test’. I haven’t noticed it before, my bad.
> You can also just use GH_TAGNAME directly instead of V. Just set:
>
> GH_TAGNAME = 1.5.0
>
> and I think not defining distname (default) should be OK.
You’re right, it doesn’t need the -${V} on the distname.
> Don't take my word as law though, I'm a newbie myself.
>
> Hope that helps.
>
> Ash
I’ll enable the tests and update port tomorrow.
Thank you for testing :)
