On Mon, Nov 09 2020, Ashton Fagg <[email protected]> wrote: > Jeremie Courreges-Anglas <[email protected]> writes: > >> Here are some items that need fixing:
tl;dr everything looks good except WANTLIB.
[...]
>> * WANTLIB is off, don't copy/paste it from other ports. You can just
>> copy/paste the suggested WANTLIB line(s) from make
>> port-lib-depends-check, with no editing:
>>
>> --8<--
>> russell /usr/ports/mystuff/devel/fmt$ make port-lib-depends-check
>>
>> fmt-7.1.1(devel/fmt):
>> Extra: pthread.26
>> russell /usr/ports/mystuff/devel/fmt$ make show=COMPILER_LIBCXX
>> c++ c++abi pthread
>> -->8--
>>
>> Dunno why libfmt isn't linked against libpthread here, but the suggested
>> WANTLIB is almost certainly correct.
>
> Addressed.
You have this line:
WANTLIB+= c++ c++abi ${COMPILER_LIBCXX}
"c++ c++abi" *is* the content of COMPILER_LIBCXX when you use
base-clang, so no need to duplicate it. The contents of COMPILER_LIBCXX
will change according to the compiler used.
So the line should be just WANTLIB = ${COMPILER_LIBCXX}, this is fixed
in the updated tarball attached, I also moved WANTLIB to follow
Makefile.template ordering and s/+=/=/ for CONFIGURE_ARGS (because
there's no technical reason to use += here, the variable isn't set at
that point).
fmt-7.1.1-jca.tgz
Description: Binary data
I think the port as-is is ripe and ready to commit, but I don't know yet if there are ports that might pick this up. [...] >> * Weird spacing: please only use tabs for indentation, not spaces then >> tabs. > > Fixed this as well, I think. There seems to be a lot of tribal knowledge > around this. Are there any written rules beyond just "use tabs" and make > it look neat? It looks fine in my emacs (screenshot attached) but I > wonder if it's misconfigured and other people are seeing it > differently. (I checked with vi and it looks the same). No idea if there are written rules somewhere. I thought it was mostly: - use tabs for indentation - try to align values in variable assignements - generally try to keep things consistent unless inconvenient Since you use emacs, M-x whitespace-mode can help (I don't use it by default because it's way too verbose but it can be configured ofc). -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
