On Sun, Nov 08, 2020 at 07:14:02PM -0500, Ashton Fagg wrote:
> Jeremie Courreges-Anglas <j...@wxcvbn.org> writes:
>
> > Well if you drop -Werror, it just builds. -Werror is often a pain in
> > ports, we tend to disable it.
>
> Thanks for the tip. I did not know if that was allowed or not. I will do
> the same to the fmt port since I'm actually explicitly setting that option.
>
> > On top of your tarball:
> > - some spacing and ordering tweaks
> > - SHARED_LIBS was a bit off. Note that SHARED_LIBS versioning should
> > start at zero, we don't respect upstream versioning (see SHARED_LIBS in
> > bsd.port.mk(5))
>
> Thanks, I goofed that in the fmt port too. I'll fix.
>
> > - PLIST regened with make update-plist
> > - WANTLIB regened with make port-lib-depends-show
> > - -DCMAKE_INSTALL_PREFIX="${PREFIX}" is the default in a port, I didn't
> > check the others -Defines
>
> I took a look at what FreeBSD does for their flatbuffers port and set
> the cmake flags to match:
>
> https://svnweb.freebsd.org/ports/head/devel/flatbuffers/Makefile?view=markup&pathrev=528335
>
> (the exception is they don't build the tests - no idea why)
>
> > I think the port is good to commit (need to check if it can be picked
> > up by other ports first). Additional reviews and oks welcome.
>
> I'd be interested to see if this works for Marc's kodi port. As I said,
> I have a couple other ports in the works that rely on this anyway. I had
> a brief look at Chromium and it's intimidating...I haven't wrapped my
> head around it enough to determine whether one can swap out the bundled
> flatbuffers or not.
I don't have a kodi port yet... I've had it configure and start building,
but it's still missing pieces.
one thing I can't figure out is why it doesn't pick up freebsd
defaults at all, even though I've mostly configured it to.
