Ashton Fagg writes:
> Ping again with an update and a correction. > > I have updated the port (attached) to the newest version of direnv. I > also noticed in my testing on a different machine, that shells/bash is a > required runtime dependency. I have corrected that as well. > > Again, portcheck is clean. > > make configure, make build, make fake, make package and make install all > succeed, package works as expected on my amd64 -current test machine. > > make test also seems to work with some caveats. I need to investigate > that and will send whatever suggestion I figure out upstream should this > get merged. > > Thanks, > > Ash Hi! You have some interesting indenting on MAINTAINER / CATEGORIES. VERSION seems to only be used once. Better to just define GH_TAGNAME and be done. USE_GMAKE can be removed - this is entirely a 'go build' situation. > pre-build: remove-github-actions I'd just move the rm in 'remove-github-actions' into the 'pre-build' target. > do-build: This can be removed too - main.go is in the top level of the repo, so the '...' isn't needed. Here is a version with the above changes - OK abieber@ for this going in if someone wants to commit it: # $OpenBSD: Makefile.template,v 1.88 2020/05/15 01:32:48 abieber Exp $ COMMENT = tool for managing environment based on current directory GH_ACCOUNT = direnv GH_PROJECT = direnv GH_TAGNAME = v2.23.1 MAINTAINER= Ashton Fagg <ash...@fagg.id.au> CATEGORIES = sysutils devel HOMEPAGE = https://direnv.net # MIT PERMIT_PACKAGE = Yes WANTLIB = c pthread MODULES = lang/go # Unfortunately, this needs bash at runtime because all the shell # stuff that happens underneath gets spawned in a bash subprocess # (even if the shell you're hooking isn't bash...go figure). RUN_DEPENDS= shells/bash # This removes some unneeded stuff. These are just # Github CI hooks. pre-build: rm -rf ${WRKSRC}/script do-install: $(INSTALL_PROGRAM) $(MODGO_WORKSPACE)/bin/direnv $(PREFIX)/bin $(INSTALL_MAN) \ $(WRKSRC)/man/direnv.1 $(PREFIX)/man/man1/direnv.1 $(INSTALL_MAN) \ $(WRKSRC)/man/direnv-stdlib.1 $(PREFIX)/man/man1/direnv-stdlib.1 $(INSTALL_MAN) \ $(WRKSRC)/man/direnv-fetchurl.1 $(PREFIX)/man/man1/direnv-fetchurl.1 $(INSTALL_MAN) \ $(WRKSRC)/man/direnv.toml.1 $(PREFIX)/man/man1/direnv.toml.1 do-test: cd ${WRKSRC}; ${MODGO_CMD} test github.com/direnv/direnv/... .include <bsd.port.mk> > > > > Ashton Fagg <ash...@fagg.id.au> writes: > >> Ping. >> >> On Sat, 24 Oct 2020 at 21:20, Ashton Fagg <ash...@fagg.id.au> wrote: >>> >>> Interest bump! >>> >>> It was also suggested that new ports should be submitted as a tarball. I >>> have addressed that (as attached). >>> >>> Thanks. >>> >>> >>> Ashton Fagg <ash...@fagg.id.au> writes: >>> >>> > Hello folks, >>> > >>> > I have created a port of direnv (https://direnv.net). It is a utility >>> > (written in Go) that hooks onto your shell, and lets you define >>> > project specific environments. >>> > >>> > Portcheck is clean. The package builds successfully, I was able to >>> > pkg_add it to my machine and test it (amd64 with zsh). >>> > >>> > There is a small example on the github page, I was able to confirm >>> > that it is working. `man direnv` and related pages also work. >>> > >>> > Any suggestions appreciated. Thanks.
