On Wed, Oct 28, 2020 at 09:36:16PM -0400, Daniel Jakots wrote: > On Wed, 14 Oct 2020 22:32:56 -0400, Daniel Jakots <d...@chown.me> wrote:
> > On Wed, 14 Oct 2020 13:06:33 +0200, Antoine Jacoutot > > <ajacou...@bsdfrog.org> wrote: > > > > Here's a diff for py-requests. I had trouble with 2.23's test > > > > suite. I found a solution for 2.24 from > > > > https://github.com/pytest-dev/pytest/issues/2042#issuecomment-429289164 > > > > There are still some failures. > > > Looks fine to me. > > > Do these failures appear in the previous version? > > No, tests in the current version are better. There are some > > failures because > > SSLError: HTTPSConnectionPool(host='127.0.0.1', port=37564): Max > > retries exceeded with url: > > /redirect-to?url=http%3A%2F%2F127.0.0.1%3A12892%2Fget (Caused by > > SSLError(CertificateError("hostname '127.0.0.1' doesn't match either > > of 'localhost', '127.0.0.1'",),)) > > which is weird. I don't remember them > > from last time I updated the port, so maybe a TDEP changed in the > > meantime? > > Anyway, I've been using the update and it works fine for me (that > > said, my requests use is quite small). > ping py-requests has a lot of consumers. Did you run through regression tests on a number of these to make sure this doesn't break them? --Kurt
