Hello everyone,

I'd really appreciate midnight commander (misc/mc) to be built with
samba support, so one can access SMB shares as local file systems,
without mounting them with sharity-light.
Also direct (directory) SMB -> FTP copy is very nice.

There would be two ways:
1. Always build with samba support (only adds about 200kb to binary).
    IMHO this is the better way.

2. Add samba flavor
    IMHO wasts space and build time.

Here are patches for both cases:
# Both work for i386 and amd64 (-current, at least rather current;)

#1
#------------------------------------------------------------------------------#
--- Makefile.orig       Tue Oct 24 16:50:13 2006
+++ Makefile    Tue Oct 24 16:54:01 2006
@@ -12,7 +12,7 @@
 
 # GPL
 PERMIT_PACKAGE_CDROM=  Yes
-PERMIT_PACKAGE_FTP=            Yes
+PERMIT_PACKAGE_FTP=    Yes
 PERMIT_DISTFILES_CDROM=        Yes
 PERMIT_DISTFILES_FTP=  Yes
 WANTLIB=               c termcap
@@ -23,8 +23,8 @@
 RUN_DEPENDS=           :unzip-*:archivers/unzip \
                        :zip-*:archivers/zip
 
-CONFIGURE_STYLE=       gnu     
-CONFIGURE_ARGS=                --with-vfs --without-mcfs --enable-charset
+CONFIGURE_STYLE=       gnu
+CONFIGURE_ARGS=                --with-samba --with-vfs --without-mcfs 
--enable-charset
 CONFIGURE_ENV=         LOCALBASE=${LOCALBASE}
 MODGNU_CONFIG_GUESS_DIRS=${WRKSRC}/config
 USE_GMAKE= Yes
#------------------------------------------------------------------------------#

#2
#------------------------------------------------------------------------------#
--- Makefile.orig       Tue Oct 24 16:50:13 2006
+++ Makefile    Tue Oct 24 16:26:22 2006
@@ -12,7 +12,7 @@
 
 # GPL
 PERMIT_PACKAGE_CDROM=  Yes
-PERMIT_PACKAGE_FTP=            Yes
+PERMIT_PACKAGE_FTP=    Yes
 PERMIT_DISTFILES_CDROM=        Yes
 PERMIT_DISTFILES_FTP=  Yes
 WANTLIB=               c termcap
@@ -23,9 +23,17 @@
 RUN_DEPENDS=           :unzip-*:archivers/unzip \
                        :zip-*:archivers/zip
 
-CONFIGURE_STYLE=       gnu     
+FLAVORS=       samba
+FLAVOR?=
+
+CONFIGURE_STYLE=       gnu
 CONFIGURE_ARGS=                --with-vfs --without-mcfs --enable-charset
 CONFIGURE_ENV=         LOCALBASE=${LOCALBASE}
 MODGNU_CONFIG_GUESS_DIRS=${WRKSRC}/config
 USE_GMAKE= Yes
+
+.if ${FLAVOR:L:Msamba}
+CONFIGURE_ARGS+=--with-samba
+.endif
+
 .include <bsd.port.mk>
#------------------------------------------------------------------------------#


Regards,
ahb

p.s. Should PKGNAME be bumped for such changes?

Reply via email to