It requires that the library be installed so 'make regress' fails.

...
cd /t/obj/ports/cfitsio-3.006/cfitsio && ./testprog >testprog.lis
./testprog: can't load library 'libcfitsio.so.0.0'
*** Error code 4

Should we point LD_LIBRARY_PATH to the fake area so this works?

Or is this patch acceptable?  Seems to be the correct thing to do.

Also worth noting is that the test itself produces unexpected
results on sparc64/amd64 and probably others...

Index: Makefile
===================================================================
RCS file: /cvs/ports/math/cfitsio/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- Makefile    12 Jun 2006 11:14:08 -0000      1.1.1.1
+++ Makefile    29 Jun 2006 00:39:09 -0000
@@ -39,6 +39,7 @@
        ${INSTALL_PROGRAM} ${WRKBUILD}/{fitscopy,imcopy,listhead} ${PREFIX}/bin
        ${INSTALL_DATA} ${WRKBUILD}/cookbook.c ${DOCDIR}
 
+REGRESS_DEPENDS=::math/cfitsio
 do-regress:
        cd ${WRKBUILD} && ${MAKE} testprog
        cd ${WRKBUILD} && ./testprog >testprog.lis

Reply via email to