On Mon, May 29, 2006 at 12:11:14AM +0200, steven mestdagh wrote:
> Tobias Ulmer [2006-05-28, 13:51:18]:
> > post-install:
> > - mkdir -p ${PREFIX}/share/examples
> > - mv ${WRKINST}/etc/${DISTNAME} ${PREFIX}/share/examples
> > + ${INSTALL_DATA_DIR} ${PREFIX}/share/examples
> > + mv ${WRKINST}${SYSCONFDIR}/${DISTNAME} ${PREFIX}/share/examples
>
> these look like scripts, so use ${INSTALL_SCRIPT}.
They are installed with correct mode, but in the wrong location. I
therefore considered mv a better choice than 4 ${INSTALL_SCRIPT} lines and
1 to delete the files (to silence update-plist).
@mode 755 in PLIST is needed because @sample ignores the mode. Maybe
that's unexpected behaviour?
>
> you could also substitute something like !!SYSCONFDIR!! in your patch
> instead of hardcoding /etc there.
SYSCONFIG is not defined for the install target. I've worked around it
by using FAKE_FLAGS. Not very nice but it works.
>
> CC strlcat.c
> CC strlcpy.c
> CC strtonum.c
done
>
> these functions are in libc. i think you can also replace their estrdup
> with our strdup(3).
>
the estrdup includes error-checking (by using emallocz), so no
> seems to work on sparc64.
>
> steven
>
> Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm
>
>
thx for testing
Tobias
wmii.tar.gz
Description: application/tar-gz
