Vladimir Támara Pati?o <[EMAIL PROTECTED]> wrote:

> I wanted to share this port.  I must say that I don't like the license of
> sword.  

A few comments:

- please remove all those unnecessary comments from the begining from
  Makefile
- we use $OpenBSD$ and not $Id$
- check other ports how LIB_DEPENDS should be used
- use ${INSTALL_*} instead of cp in install target
- is V var really needed?  It's used only once, right?
- are you sure that you are using -current system? pkg/COMMENT? ${WWW}
  and the ond of pkg/DESCR?!
- please don't hardcode /usr/local in pkg/DESCR.  Anyway, I'm not sure
  if that comment about adding export to .profile should be in pkg/DESCR

Cheers,

Alek
-- 
Dolsilwa klął szpetnie [...] Nauczył się tego na Zachodzie, gdzie
przekleństwa miały charakter szczególny. Mianowicie mieszkańcy [...]
przekleństwami zniechęcali bogów do wszelakich ingerencji w bieg spraw
[...] Nie pomagało oczywiście, lecz klęli jak nikt na całym świecie.

Reply via email to