On Thu, Sep 22, 2005 at 09:10:03AM +0200, Aleksander Piotrowski wrote:
> Simon Dassow <[EMAIL PROTECTED]> wrote:
> 
> > Now for real and with the bits attached...
> 
> So, you sent us following ports:
> 
> ./devel/p5-Class-Accessor
[...]
> ./devel/p5-Module-Build

Updates not required, as noted by Mathieu.

> ./devel/p5-Module-Pluggable-Fast
> 
> - COMMENT shouldn't start with an "a"

Fixed.

> - Please use MASTER_SITE similar to other perl ports (i.e. don't use
>   "by-authors" in it).  It looks like simple ...=Module/} works fine

I tried, but the distfiles were't found that way... mirroring issue?

> - Are you sure that LIB_DEPENDS is needed?

No, i changed them to BUILD_DEPENDS.

> - If it's pure perl code (no shared modules, etc.) then please add
>   PKG_ARCH=*

Done.

> - Looks like regression tests need p5-Test-Pod(-Coverage), so please add
>   proper REGRESS_DEPENDS

Done.

> ./devel/p5-Path-Class
[...]

Same as above.

> ./devel/p5-Tree-Simple-VisitorFactory
[...]

Same as above and updated plist.

> ./textproc/p5-Text-ASCIITable
[...]
> ./www/p5-Catalyst

Same as above :-)

Updated ports are attached... actualy ;-)

Kind regards,
Simon

Attachment: catalyst.tar.gz
Description: application/tar-gz

Reply via email to