Jonathan Gray <[EMAIL PROTECTED]> wrote: > Unshield is a program and library for extracting files from > InstallShield cabinet files. Tested on i386 only so far.
Looks fine but ... o COMMENT shouldn't start with capital letter o NO_REGRESS is not needed. We add it only if running make regress gives an error. That's not the case as make regress ends up with: ===> Regression check for unshield-0.5 Making check in lib Making check in md5 Making check in . Making check in src Making check in . and this is OK. o Looks like this port uses -g by default, no? o pkg/DESCR isn't wrapped properly. It should have 72 chars per line (just run it through fmt -w 72) o On sparc64 I had to use attached patch in order to compile unshield Cheers, Alek -- But software which OpenBSD uses and redistributes must be free to all (be they people or companies), for any purpose they wish to use it, including modification, use, peeing on, or even integration into baby mulching machines or atomic bombs to be dropped on Australia. -- Theo de Raadt, [EMAIL PROTECTED]
$OpenBSD$ --- lib/internal.h.orig Sat Jul 9 13:11:23 2005 +++ lib/internal.h Sat Jul 9 13:11:16 2005 @@ -109,8 +109,12 @@ uint16_t bswap_16(uint16_t x); uint32_t bswap_32(uint32_t x); #endif +#ifndef letoh16 #define letoh16(x) bswap_16(x) +#endif +#ifndef letoh32 #define letoh32(x) bswap_32(x) +#endif #else #define letoh32(x) (x)
