On 7/4/2005, "Jacob Meuser" <[EMAIL PROTECTED]> wrote:
>On Mon, Jul 04, 2005 at 11:32:47AM +0100, Edd Barrett wrote: >> Hello, >> >> Here is a port for eq-xmms. A plugin that will allow equalization of any >> file format, not just mp3. >> >> I've had great results with this piece of software EQ'ing my vorbis >> files, but as for the build, I'm not sure and would like your opinions. >> >> The configure script is linux-centric. It reads /proc/cpuinfo to see >> what arch your machine is and if it has SSE and MMX and all the other >> buzzwords. If this fails (obviously in obsd it does) then it assumes x86 >> . I tried building on my sparc and it failed. For now all I have done is >> patched the configure script to not make that assumption. Its a dirty >> hack I know. >> >> I did try playing around with cpudetect.c and I tried things like >> getting arch from param.h, but they ended up being even dirtier ,as it >> has already made the x86 assumption. >> >> What do you guys think? > >I think you are abusing WANTLIB and forgetting about LIB_DEPENDS. > >also, I think a better name would be xmms-equ. note that the other >xmms plug-ins are named xmms-<whatever>. > >-- ><[EMAIL PROTECTED]> > >-- >This email has been verified as Virus free >Virus Protection and more available at http://www.plus.net > Hi, Thanks for yor comments, I will look into that. Did you have any comments on the build itself? Did you take a look at cpudetect.c and configure? As I say, I'm unsure the best way to patch this to build. Edd
