When you render an annotation is not in scope for the spec - just *how* you render them.
Leonard On 2/16/18, 9:56 AM, "poppler on behalf of Tobias Deiminger" <[email protected] on behalf of [email protected]> wrote: Hi Leonard! > Are you talking about rendering them according to the spec or something > else? I'm talking about rendering them according to spec, but "standalone". So far Poppler can only render page-wise, it has no API to render a specific annotation of interest. That's what I'm trying to add. Afaik that's not in conflict with the spec, is it? > ISO 32000 is very clear that an annotation is rendered by simply > drawing the relevant appearance stream. As such, there isn't much to > test. Poppler dynamically generates appearance streams for annotations that don't have an embedded appearance. That's not a trivial task, so IMHO unit tests wouldn't hurt there too. But that's not my main concern. I'm mostly reusing existing poppler code wrt this and trust the guys who did it. I'd like to test my new feature, like "does the annotation exactly fit into the generated QImage?", "does it have the correct resolution?", "does it use the correct rendering settings (acc. to the document hints)?", "does it segfault?", and so on. > Or are you doing something else? I'll send you a preview of the patch, then you'll know what it's about. Tobias _______________________________________________ poppler mailing list [email protected] https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fpoppler&data=02%7C01%7Clrosenth%40adobe.com%7Cec5113b9375b4fa55dd808d5754d765f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636543897923783119&sdata=miGY%2BKlvNI7sEBCMPvkRohFADgk4Sm2Nmi%2FyT4%2Furl0%3D&reserved=0 _______________________________________________ poppler mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/poppler
