Can you guys check I'm not doing something crazy?

Seems we don't really need to store box_color at all and just pass it down, 
no?

Cheers,
  Albert
diff --git a/poppler/TextOutputDev.cc b/poppler/TextOutputDev.cc
index 4adb3c2..0938176 100644
--- a/poppler/TextOutputDev.cc
+++ b/poppler/TextOutputDev.cc
@@ -4284,7 +4284,7 @@ public:
 
 private:
   OutputDev *out;
-  GfxColor *box_color, *glyph_color;
+  GfxColor *glyph_color;
   GfxState *state;
   GooList *selectionList;
   Matrix ctm, ictm;
@@ -4298,7 +4298,6 @@ TextSelectionPainter::TextSelectionPainter(TextPage *page,
 					   GfxColor *glyph_color)
   : TextSelectionVisitor(page),
     out(out),
-    box_color(box_color),
     glyph_color(glyph_color)
 {
   PDFRectangle box(0, 0, page->pageWidth, page->pageHeight);
_______________________________________________
poppler mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/poppler

Reply via email to