A Dijous, 28 de juliol de 2011, Albert Astals Cid vàreu escriure: > A Dimarts, 29 de març de 2011, Thomas Freitag vàreu escriure: > > On 29.03.2011 00:54, Albert Astals Cid wrote: > > > A Dilluns, 28 de març de 2011, Thomas Freitag va escriure: > > >> Here now a first implementation of overprint in poppler. > > >> > > >> But beside this open issues the output seems to be quite well and shows > > >> a better output. > > > Is not clear to me if the mail you sent is just a progress report or you > > > actually want the code to be added to poppler (i.e. reviewed and tested). > > > > > > Could you clarify that? > > I actually want the code to be added to poppler: > > a) in splashModeCMYK8 it is all we can do (simulating overprint), and it > > has really big enhancements. > > b) implementing splashModeDeviceN will be a bigger project and have to > > wait at least until my next vacation. > > c) perhaps one of the front end developper want to create a new option > > "simulate overprint" simular to Acrobat Reader in the meantime? > > > > BTW, if You take my first patch for pdftoppm only as a start point, i.e. > > run it with the new option "-overprint" over Your test suite, and then > > run the overprint implementation patch with the option "-overprint" > > against it, so really a regression test, You'll see the enhancements of > > the overprint patch. > > Just started the testing of this (yeah 6 months later, sorry :-/) and when > compiling i get this warnings > > JpegWriter.cc:66:9: warning: enumeration value ‘JCS_UNKNOWN’ not handled in > switch [-Wswitch] > JpegWriter.cc:66:9: warning: enumeration value ‘JCS_YCbCr’ not handled in > switch [-Wswitch] > JpegWriter.cc:66:9: warning: enumeration value ‘JCS_YCCK’ not handled in > switch [-Wswitch] > JpegWriter.cc:66:9: warning: enumeration value ‘JCS_EXT_RGB’ not handled in > switch [-Wswitch] > JpegWriter.cc:66:9: warning: enumeration value ‘JCS_EXT_RGBX’ not handled in > switch [-Wswitch] > JpegWriter.cc:66:9: warning: enumeration value ‘JCS_EXT_BGR’ not handled in > switch [-Wswitch] > JpegWriter.cc:66:9: warning: enumeration value ‘JCS_EXT_BGRX’ not handled in > switch [-Wswitch] > JpegWriter.cc:66:9: warning: enumeration value ‘JCS_EXT_XBGR’ not handled in > switch [-Wswitch] > JpegWriter.cc:66:9: warning: enumeration value ‘JCS_EXT_XRGB’ not handled in > switch [-Wswitch] > > I guess you are missing a default: that does nothing/returns an > error/something.
I've commited your patch adding a "return false;" as default in the switch. Albert > > Albert > > > > > Thomas > > > Thanks, > > > Albert > > > > > >> Thomas > > > _______________________________________________ > > > poppler mailing list > > > [email protected] > > > http://lists.freedesktop.org/mailman/listinfo/poppler > > > > > > . > > > > > > > > > _______________________________________________ > > poppler mailing list > > [email protected] > > http://lists.freedesktop.org/mailman/listinfo/poppler > _______________________________________________ > poppler mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/poppler > _______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
