A Dimarts, 6 d'abril de 2010, Hib Eris va escriure: > Hi all, > > I have updated the patches taking Albert's comments into account. > > On Mon, Apr 5, 2010 at 11:50 PM, Albert Astals Cid <[email protected]> wrote: > > Some comments: > > * You don't initialize pageMode nor pageLayout to their null enum > > values. * I'd like the new enum values to be added to the end to be more > > saf in case anyone was using the int values to save them somewhere > > * You should be freeing catDict > > > >> The last patch in this series is almost certainly incorrect, but I > >> would like some input on it. It is dealing with form widgets. > >> Question: can this postWidgetsLoad() be done on a per page basis, or > >> is it something global to the whole document? > > > > Probably it could be done per page, if you give a patch i can test all > > docs in my regression suite to see if we get the same behaviour with > > your patches or not. > > Okay, for now I have left this last patch out of the new patch set. I > will study the details of annotations and formfields some more to come > up with a better patch. > > > Also, can you please enlight us what does this give us towards getting > > linearized support? > > The goal of linearized support is to be able to render any page in a > document without downloading any unrelated/unnecessary objects. To > prevent downloading unnecessary objects, the Catalog should only > initialize what is absolutely needed and defer initializing anything > else to a when it is needed. > > Linearized support while still initializing objects from all over the > document is just not very useful, so I thought it would be wise to > first do these things.
Pushed. Albert > > Hib _______________________________________________ poppler mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/poppler
