Hi, 

I've been reviewing forms code in the glib bindings and I think that
current API is a little bit confusing. Having two different interfaces
(PopplerDocument and PopplerFormfield) for handling forms doesn't look
natural to me. So, I propose to use only one interface based on
PopplerFormField. Instead of create structures to pass forms information
to the frontends, we can just use an opaque object, like poppler-page,
that wraps FormWidget. This object has methods for both getting and
setting. Finally, in PopplerDocument we only need one method to be able
to get a PopplerFormField from its id. 

In addition, I suggest to use a PopplerFormFieldMapping, instead of
including the coords information in the FormField object, for
consistency with the current API (links and images). 

Here is a patch that implements these suggestions:

http://people.freedesktop.org/~carlosgc/poppler-glib-forms.diff

what do you guys think? Julien?

-- 
Carlos Garcia Campos
   [EMAIL PROTECTED]
   [EMAIL PROTECTED]
   http://carlosgc.linups.org
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462

Attachment: signature.asc
Description: Esta parte del mensaje está firmada digitalmente

_______________________________________________
poppler mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/poppler

Reply via email to