Send plymouth mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.freedesktop.org/mailman/listinfo/plymouth
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of plymouth digest..."
Today's Topics:
1. [PATCH] Provide --help option to display usage of
plymouth-set-default-theme (Adrian Glaubitz)
2. Re: [PATCH] Provide --help option to display usage of
plymouth-set-default-theme (Adrian Glaubitz)
3. Re: [PATCH] Provide --help option to display usage of
plymouth-set-default-theme (Ray Strode)
4. Re: [PATCH] Provide --help option to display usage of
plymouth-set-default-theme (Adrian Glaubitz)
----------------------------------------------------------------------
Message: 1
Date: Sat, 5 Dec 2009 14:45:09 +0100
From: Adrian Glaubitz <[email protected]>
Subject: [PATCH] Provide --help option to display usage of
plymouth-set-default-theme
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
Hi,
when running new, unfamiliar commands I usually invoke them with
--help to see what options they have. For plymouth-set-default-theme,
there is no --help option which I find a bit confusing, especially
since the usage is not straight-forward. Since there is a usage
function in the script anyway, I wrote a small patch to provide a
--help option to display the usage.
Moreover, I think, the usage output should be overhauled a bit, but I
think that should go into a second patch.
Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: plymouth_provide_--help.patch
Type: text/x-diff
Size: 694 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/plymouth/attachments/20091205/95679ef7/attachment-0001.patch
------------------------------
Message: 2
Date: Sat, 5 Dec 2009 15:19:27 +0100
From: Adrian Glaubitz <[email protected]>
Subject: Re: [PATCH] Provide --help option to display usage of
plymouth-set-default-theme
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
Hi,
On Sat, Dec 05, 2009 at 02:45:09PM +0100, Adrian Glaubitz wrote:
> when running new, unfamiliar commands I usually invoke them with
> --help to see what options they have. For plymouth-set-default-theme,
> there is no --help option which I find a bit confusing, especially
> since the usage is not straight-forward. Since there is a usage
> function in the script anyway, I wrote a small patch to provide a
> --help option to display the usage.
>
> Moreover, I think, the usage output should be overhauled a bit, but I
> think that should go into a second patch.
I have improved the previous patch a bit and now there is an
additional function "show_help" which displays an extensive help when
invoking plymouth-set-default-theme with --help. The original function
usage is still there since it always be called when the script is
invoked with wrong parameters.
Please see the attached new patch.
Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: plymouth_provide_better_help.patch
Type: text/x-diff
Size: 1508 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/plymouth/attachments/20091205/ea3ab38d/attachment-0001.patch
------------------------------
Message: 3
Date: Sat, 5 Dec 2009 12:13:45 -0500
From: Ray Strode <[email protected]>
Subject: Re: [PATCH] Provide --help option to display usage of
plymouth-set-default-theme
To: Adrian Glaubitz <[email protected]>
Cc: [email protected]
Message-ID:
<[email protected]>
Content-Type: text/plain; charset=UTF-8
On Sat, Dec 5, 2009 at 9:19 AM, Adrian Glaubitz
<[email protected]> wrote:
> Hi,
>
> On Sat, Dec 05, 2009 at 02:45:09PM +0100, Adrian Glaubitz wrote:
>> when running new, unfamiliar commands I usually invoke them with
>> --help to see what options they have. For plymouth-set-default-theme,
>> there is no --help option which I find a bit confusing, especially
>> since the usage is not straight-forward. Since there is a usage
>> function in the script anyway, I wrote a small patch to provide a
>> --help option to display the usage.
>>
>> Moreover, I think, the usage output should be overhauled a bit, but I
>> think that should go into a second patch.
>
> I have improved the previous patch a bit and now there is an
> additional function "show_help" which displays an extensive help when
> invoking plymouth-set-default-theme with --help. The original function
> usage is still there since it always be called when the script is
> invoked with wrong parameters.
>
> Please see the attached new patch.
Thanks, this looks good. I've commited this here:
http://cgit.freedesktop.org/plymouth/commit/?id=e40e0b8719fcb1408496e9937f6bf89b98c4da54
and then made a quick change here:
http://cgit.freedesktop.org/plymouth/commit/?id=e40e0b8719fcb1408496e9937f6bf89b98c4da54
Have a great weekend,
--Ray
------------------------------
Message: 4
Date: Sat, 5 Dec 2009 18:58:56 +0100
From: Adrian Glaubitz <[email protected]>
Subject: Re: [PATCH] Provide --help option to display usage of
plymouth-set-default-theme
To: Ray Strode <[email protected]>
Cc: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Hi Ray,
On Sat, Dec 05, 2009 at 12:13:45PM -0500, Ray Strode wrote:
> On Sat, Dec 5, 2009 at 9:19 AM, Adrian Glaubitz
> <[email protected]> wrote:
> >
> > Please see the attached new patch.
> Thanks, this looks good. I've commited this here:
>
> http://cgit.freedesktop.org/plymouth/commit/?id=e40e0b8719fcb1408496e9937f6bf89b98c4da54
>
> and then made a quick change here:
>
> http://cgit.freedesktop.org/plymouth/commit/?id=e40e0b8719fcb1408496e9937f6bf89b98c4da54
thanks, that was fast. Great that you reviewed and spruced it up a
bit.
I wanted to write a small manpage "plymouth" within the next days as
well. Maybe that could be included, too.
Have a nice weekend, too,
Adrian
------------------------------
_______________________________________________
plymouth mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/plymouth
End of plymouth Digest, Vol 15, Issue 1
***************************************
