broulik created this revision. broulik added reviewers: Plasma, mart, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY The dictionary engine lets us specify a server and dictionary but we don't need any of that, and the engine can deal with just a word (these days?). More importantly, the key inserted into the `m_lockers` map is without a colon and since `sourceRemoved` is also called without it, the wait condition is never met and we time out eventually. The colon has been in there forever but from current dictionary engine code I don't see why it would be neccessary. TEST PLAN 5.16 branch? - Together with D21605 <https://phabricator.kde.org/D21605> (or on 5.16 with old milou model) dictionary runner finds stuff again "define test" REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22814 AFFECTED FILES runners/dictionary/dictionarymatchengine.cpp To: broulik, #plasma, mart, kossebau Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
