guoyunhe added inline comments. INLINE COMMENTS
> ngraham wrote in potdprovider.cpp:54 > The lack of error handling and else blocks for all the ifs in this new code > makes me feel a bit nervous. `date` is optional, so if it not found, just leave it as undefined. I can add some detection to `toString()` function, in case they passed some non-string args. `mach()` should be safe. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22494 To: guoyunhe, #plasma Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
