davidedmundson added inline comments.
INLINE COMMENTS
> resultsmodel.cpp:154
> +
> +class HideRootLevelProxyModel : public QSortFilterProxyModel
> +{
Future Kai is going to appreciate some docs on what each class does.
> runnerresultsmodel.cpp:146-148
> + // Now that the source data has been updated, emit the data changes
> we noted down earlier
> + if (signalDataChanged) {
> + emit dataChanged(index(0, 0, categoryIdx),
> index(endOfUpdateableRange, 0, categoryIdx));
Urgh, we've done this style before and it resulted in obscure QtQuick crashes.
For QtQuick we need to insert new rows for new rows, not just insert/remove the
difference and emit changed on everything, otherwise we mess up the delegates.
See 9371a7c96d4722b93b49b18df7b21780f2a9ad38
<https://phabricator.kde.org/R119:9371a7c96d4722b93b49b18df7b21780f2a9ad38> in
p-d
Sorry.
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D22735
To: broulik, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
