hein added a comment.

  Thanks, this looks a lot better and cleaner. Minor nitpick to clean up.

INLINE COMMENTS

> ItemGridView.qml:440
> +                    itemGrid.itemActivated(pressedItem.itemIndex, "", null);
> +                } else if (!dragHelper.dragging && !pressedItem && 
> mouse.button == Qt.LeftButton)
> +                    root.toggle();

Coding style: Even for single-line blocks we require braces.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Reply via email to