ngraham created this revision. ngraham added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY The preview window doesn't respond to setting its visibility to false, so currently it can't actually be closed without using the task manager or another external way of closing windows. Fix the issue by triggering the window's `close()` function instead. TEST PLAN Preview a theme and click on the close button, or anywhere else, or hit the Esc key REPOSITORY R119 Plasma Desktop BRANCH make-lnf-preview-escapeable (branched from Plasma/5.16) REVISION DETAIL https://phabricator.kde.org/D22543 AFFECTED FILES kcms/lookandfeel/package/contents/ui/main.qml To: ngraham, #plasma, apol Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart