broulik added inline comments.

INLINE COMMENTS

> sourcesmodel.cpp:43
>              this, SLOT(slotMatchesChanged(QList<Plasma::QueryMatch>)));
> +    connect(m_manager, &Plasma::RunnerManager::queryFinished,
> +            this, [this] {

From my testing this signal isn't realibly emitted, without D21606 
<https://phabricator.kde.org/D21606> and some other fix. See also Bug 381835
Are you sure this patch actually works?

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D22513

To: apol, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Reply via email to