jgrulich added inline comments.

INLINE COMMENTS
> handler.cpp:170
> +{
> +    NetworkManager::AccessPoint::Ptr ap;
> +    NetworkManager::WirelessDevice::Ptr wifiDev;

I actually thought that instead of all this logic, where you search for 
wireless device, AP and then to get the security type, you will pass those 
information from the applet, instead of the **specificObject**. Even ssid is 
exposed from the model so you can just pass ssid as an argument and security 
type as another one and almost all this code below can go away.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to