ndavis added a comment.
The latest version of this patch is better because it works well for people using the Breeze GTK theme with the Breeze colorscheme and it doesn't make the Breeze Dark GTK theme worse when combined with the Breeze Dark colorscheme. However, it does cause Breeze GTK to look odd when used with the Breeze Dark colorscheme: F7027817: Screenshot_20190715_124709.png <https://phabricator.kde.org/F7027817> Normally, I wouldn't consider this too much of a problem since people usually want to use the same theme system wide, but sometimes apps that use GTK themes don't play well with dark GTK themes. It is realistic to assume some people who normally use Breeze Dark will use the Breeze GTK theme for GTK apps via the system settings rather than an environment variable for the few problematic apps (`GTK_THEME=Breeze app-name-here`). Examples of apps that don't play well with dark GTK themes are Eclipse, Intellij IDEA <https://phabricator.kde.org/file/data/7x4wgf3q3pawfkdkakjf/PHID-FILE-vy5cmecnuljriju5ve2d/Screenshot_20190715_130024.png> and Firefox (before version 68). REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: cblack, ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
