apol added inline comments.
INLINE COMMENTS
> debugger.cpp:145
> + // as binary blob (e.g. Windows exe).
> +
> QString(QStringLiteral("%1/%2")).arg(QCoreApplication::applicationDirPath(),
> path),
> + // Search in default path
The QString constructor isn't necessary.
Actually it would be better written as `QCoreApplication::applicationDirPath()
+ QLatin1Char('/') + path`
> debugger.cpp:151
> + QHash<QString, Debugger> result;
> + for (const auto &debuggerDir: debuggerDirs) {
> QStringList debuggers = QDir(debuggerDir).entryList(QDir::Files);
qAsConst(debuggerDirs);
> debugger.cpp:152
> + for (const auto &debuggerDir: debuggerDirs) {
> QStringList debuggers = QDir(debuggerDir).entryList(QDir::Files);
> + for (const auto &debuggerFile : debuggers) {
const
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D22401
To: sitter, #plasma
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, mart
