ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.
In D22191#493985 <https://phabricator.kde.org/D22191#493985>, @filipf wrote: > If that's the case then the whole KCM needs to be disabled because any change made within it entails writing to root. This would be relevant to the function though when abstracted and used throughout KCMs. Another thing that crosses my mind in regards to failing is BSD (due to different generic paths), but I have no idea if they even use SDDM. Hmm, that's true, so this is a pre-existing issue then. Okay, let's get this in and focus on polishing it in subsequent revisions! REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH sddm-theme-syncing (branched from master) REVISION DETAIL https://phabricator.kde.org/D22191 To: filipf, #plasma, ngraham, davidedmundson, #vdg Cc: leinir, cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
