ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > Activities.cpp:218 > + auto a = q->ListActivitiesWithInformation(); > + std::sort(a.begin(), a.end(), &infoLessThan); > + I don't like the fact that it constantly resorts the activities. The second problem is that ListActivities returns a list in one order, and this traverses activities in another order. If this will work by name, probably the List functions should as well. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D22381 To: muesli, ivan Cc: ivan, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
