nicolasfella created this revision. nicolasfella added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision.
REVISION SUMMARY The current system tray settings has two pages with two slightly different lists. The first page shows a list of all available plasmoids and allows to en/disable them. The second list shows the in the previous page enabled plasmoids plus the available statusnotifieritems and offers configuration (visibility and shortcuts for plasmoids). This patch combines both into a single list. Therefor it: - Has a new model that holds both plasmoids and SNIs - Replaces the QQC1 Tableview with a ListView + Rowlayout - Adds an entry 'Disabled' to the visibility combobox to disable plasmoids (functionality from the former first list) - Removes the old 'General' page This removes the ability to (de-)select entire categories, but I don't consider this a particularly useful feature. The categories are intransparent to the user and the individual elements can still be en/disabled Currently it has a slight visual bug. The scrollbar overlaps the shortcut clear buttons. Help to resolve this is welcome BUG: 360307 BUG: 397950 TEST PLAN Open system tray. Change the visibility of a plasmoid. Apply. Verify visibility in system tray. Add a shortcut to plasmoid. Verify shortcut REPOSITORY R120 Plasma Workspace BRANCH systray REVISION DETAIL https://phabricator.kde.org/D22176 AFFECTED FILES applets/systemtray/CMakeLists.txt applets/systemtray/entrymodel.cpp applets/systemtray/entrymodel.h applets/systemtray/package/contents/config/config.qml applets/systemtray/package/contents/ui/ConfigEntries.qml applets/systemtray/package/contents/ui/ConfigGeneral.qml applets/systemtray/systemtray.cpp applets/systemtray/systemtray.h To: nicolasfella, #plasma, #vdg Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
