davidedmundson added inline comments.

INLINE COMMENTS

> KickoffListView.qml:142
> +                        if (item.appView) {
> +                            if (mouse.source == 
> Qt.MouseEventSynthesizedByQt) {
> +                                positionChanged(mouse);

why do we need this?

> KickoffListView.qml:204
> +                     if (mouse.source == Qt.MouseEventSynthesizedByQt) {
> +                        tapandhold = true;
> +                        positionChanged(mouse);

we tend to useCamelCaseForVariables

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff

REVISION DETAIL
  https://phabricator.kde.org/D21829

To: steffenh, #plasma, hein, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to