filipf added a comment.
Awesome, the look of that menu has been a thorn in my side! Code needs some
modifications, but it looks great.
Can you also apply this patch to KeyboardButton.qml as we've got another QQC
menu there?
INLINE COMMENTS
> SessionButton.qml:48
> + frame: Rectangle {
> + color: "#fcfcfc"
> + }
No need to hardcode here, instead set:
`color: PlasmaCore.ColorScope.backgroundColor`
> SessionButton.qml:53
> + verticalAlignment: Text.AlignVCenter
> + color: styleData.selected ? "#fcfcfc" : "#232627"
> + text: styleData.text
Same, you can set:
`color: styleData.selected ? PlasmaCore.ColorScope.highlightedTextColor :
PlasmaCore.ColorScope.textColor`
> SessionButton.qml:55
> + text: styleData.text
> + }
> + itemDelegate.background: Rectangle {
For this label we should also add:
`font.pointSize: config.fontSize`
This will make sure the size of the labels is the same as the one used for the
button label.
> SessionButton.qml:58
> + visible: styleData.selected
> + color: "#3daee9"
> + //border.color: "#3daee9"
PlasmaCore.ColorScope.highlightColor
> SessionButton.qml:59
> + color: "#3daee9"
> + //border.color: "#3daee9"
> + //border.width: 1
Just remove this, you would be trying to mimic the PlasmaComponents.Highlight
with it, but that's not what we use in menus in the desktop.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21794
To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel,
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
