zzag added inline comments.

INLINE COMMENTS

> notification_p.h:53
>  
> +    static KService::Ptr serviceForDesktopEntry(const QString &desktopEntry);
> +

A bit off topic: is there any point for making this method static? You could 
get away with making serviceForDesktopEntry function static in the cpp file.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21779

To: broulik, #plasma, sitter, davidedmundson
Cc: zzag, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Reply via email to